Re: [Xen-devel] [PATCH v2 1/4] x86/PVHv2: Add memory map pointer to hvm_start_info struct

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Mar 15, 2018 at 01:22:24AM -0600, Jan Beulich wrote:
> >>> On 14.03.18 at 21:07, <maran.wilson@xxxxxxxxxx> wrote:
> > OK, I think I'm following the specifics now. But just to make sure we 
> > all on the same page before sending out the next version...
> > 
> > I'll be adding something like the following to the header file:
> > 
> > ...
> > /*
> >   * For x86 implementations at least, the values used in the type field 
> > of the
> >   * memory map table entries are defined below and match the Address 
> > Range Types
> >   * as defined in section 15 (System Address Map Interfaces) of the ACPI
> >   * Specification (http://uefi.org/specifications)
> >   */
> > #define PVH_MEMMAP_TYPE_RAM       1
> > #define PVH_MEMMAP_TYPE_RESERVED  2
> > #define PVH_MEMMAP_TYPE_ACPI      3
> > #define PVH_MEMMAP_TYPE_NVS       4
> > #define PVH_MEMMAP_TYPE_UNUSABLE  5
> > #define PVH_MEMMAP_TYPE_PMEM      7
> > ...
> > 
> > And then we will find an appropriate place in the c code to add a couple 
> > of BUILD_BUG_ON() macros to make sure the above remain consistent with 
> > E820_xxx.
> > 
> > Does that sound about right?
> 
> About, yes. Subject to the name prefix adjustment as per the other
> reply (to Boris) just sent. Plus I'm not convinced of the x86
> restriction here: There's nothing x86-specific about these in the
> ACPI spec.

This header and interface is already x86 specific ATM, so I would
simply avoid the starting "For x86...". Iff this is ever used by
other arches we can then decide what to do with the memory types.

The rest LGTM (modulo Jan's requested changes).

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel