Re: [Xen-devel] [PATCH v5 03/16] xen/arm: mm: Use gaddr_to_gfn rather than _gfn(paddr_to_pfn(...))

[George Dunlap <dunlapg@xxxxxxxxx>]

On Wed, Mar 14, 2018 at 6:19 PM,  <julien.grall@xxxxxxx> wrote:
> From: Julien Grall <julien.grall@xxxxxxx>
>
> The construction _gfn(paddr_to_pfn(...)) can be simplified by using
> gaddr_to_gfn.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>

Not sure if "simplified" is the right word here (and in the previous
patch); simplified implies fewer steps in the calculation, but it
looks like the steps so far are identical.  Using a macro rather than
hand-coding stuff is cleaner and more maintainable; don't think it
really needs to be justified.

In any case:

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel