[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: fix null sched build with debug=n



>>> On 19.03.18 at 03:20, <cardoe@xxxxxxxxxx> wrote:
> The null_dom() static inline is just used when debug=y so it results in
> a error with the default CFLAGS and debug=n.
> 
> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
> ---
> sched_null.c:123:32: error: unused function 'null_dom' 
> [-Werror,-Wunused-function]

Since generally only non-inline functions get warned about by gcc
(afaik), I'm wondering: Is this with clang? Or with some specific,
non-standard version of gcc? Adding such specifics to the commit
message would generally be advisable (and indeed I'm not really
happy to see such an #ifdef added, but then again I'm not the
maintainer of that code).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.