Re: [Xen-devel] [PATCH] xen: fix null sched build with debug=n

[Dario Faggioli <dfaggioli@xxxxxxxx>]

On Mon, 2018-03-19 at 03:40 -0600, Jan Beulich wrote:
> > > > On 19.03.18 at 03:20, <cardoe@xxxxxxxxxx> wrote:
> > 
> > The null_dom() static inline is just used when debug=y so it
> > results in
> > a error with the default CFLAGS and debug=n.
> > 
> > Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
> > ---
> > sched_null.c:123:32: error: unused function 'null_dom' 
> > [-Werror,-Wunused-function]
> 
> Since generally only non-inline functions get warned about by gcc
> (afaik), I'm wondering: Is this with clang? Or with some specific,
> non-standard version of gcc? Adding such specifics to the commit
> message would generally be advisable (and indeed I'm not really
> happy to see such an #ifdef added, but then again I'm not the
> maintainer of that code).
>
I don't like that either.

Since it's used only once, it can well be killed, and
v->domain->sched_priv be used in null_vcpu_check().

We'll reintroduce the helper if/when actually necessary.

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel