Re: [Xen-devel] [PATCH v1] hvm/svm: Implement Debug events

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/03/18 14:07, Alexandru Isaila wrote:
> -    case VMEXIT_EXCEPTION_BP:
> -        inst_len = __get_instruction_length(v, INSTR_INT3);
> +    case VMEXIT_EXCEPTION_BP:;
> +        inst_len = vmcb->nextrip - vmcb->rip;

Sorry, but no.  This will break on older AMD hardware.  You must retain
the __get_instruction_length().

NextRIP support was only introduced in Gen2 SVM, and we still support Gen1.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel