Re: [Xen-devel] [PATCH v1] hvm/svm: Implement Debug events

[Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>]

On Lu, 2018-03-19 at 14:22 +0000, Andrew Cooper wrote:
> On 19/03/18 14:07, Alexandru Isaila wrote:
> > 
> > -    case VMEXIT_EXCEPTION_BP:
> > -        inst_len = __get_instruction_length(v, INSTR_INT3);
> > +    case VMEXIT_EXCEPTION_BP:;
> > +        inst_len = vmcb->nextrip - vmcb->rip;
> Sorry, but no.  This will break on older AMD hardware.  You must
> retain
> the __get_instruction_length().
> 
> NextRIP support was only introduced in Gen2 SVM, and we still support
> Gen1.
> 
> ~Andrew
Yes, you are right, I will re-use the __get_instruction_length() and
add support for the ICEBP instruction fort the next version of the
patch. Just did some tests and it works fine for the int3/int $3
instruction length.

Thanks for the heads-up. 

~Alex 
> 
> ________________________
> This email was scanned by Bitdefender
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel