Re: [Xen-devel] [PATCH v4 3/4] libxl: Store e820 map in xc_dom_image

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 03/21/2018 05:42 AM, Roger Pau Monné wrote:
> On Tue, Mar 20, 2018 at 09:50:51AM -0700, Maran Wilson wrote:
>> From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>> diff --git a/tools/libxl/libxl_x86.c b/tools/libxl/libxl_x86.c
>> index 7cbbfd0..651b7d5 100644
>> --- a/tools/libxl/libxl_x86.c
>> +++ b/tools/libxl/libxl_x86.c
>> @@ -582,6 +582,10 @@ static int domain_construct_memmap(libxl__gc *gc,
>>          goto out;
>>      }
>>  
>> +    dom->e820 = libxl__malloc(gc, e820_entries * sizeof(*(dom->e820)));
>> +    dom->e820_entries = e820_entries;
>> +    memcpy(dom->e820, e820, e820_entries * sizeof(*(dom->e820)));
> e820 is already allocated with libxl_malloc, why not simply use:
>
> dom->e820 = e820;
> dom->e820_entries = e820_entries;

Sure, I can do this.

-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel