Re: [Xen-devel] [PATCH v3 1/4] x86/hvm: stop passing explicit domid to hvm_create_ioreq_server()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 20/03/18 18:05, Paul Durrant wrote:
> Only in the legacy 'default server' case do we pass anything other than
> current->domain->domain_id, and in that case we pass the value of
> HVM_PARAM_DM_DOMAIN.
>
> The only known user of HVM_PARAM_DM_DOMAIN is qemu-trad, which always sets

I'd include the fact that it is even only when compiled as a stubdom.

> it to DOMID_SELF (ignoring the return value of xc_set_hvm_param) [1] and
> never reads it.
>
> This patch:
>
> - Disallows setting HVM_PARAM_DM_DOMAIN to anything other than DOMID_SELF
>   and removes the call to hvm_set_dm_domain().
> - Stops passing a domid to hvm_create_ioreq_server()
> - Changes hvm_create_ioreq_server() to always set
>   current->domain->domain_id as the domid of the emulating domain
> - Removes the hvm_set_dm_domain() implementation since it is no longer
>   needed.
>
> [1] 
> http://xenbits.xen.org/gitweb/?p=qemu-xen-traditional.git;a=blob;f=hw/xen_machine_fv.c;#l299
>
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel