Re: [Xen-devel] [PATCH v5 3/5] x86/cpuid: update signature of hvm_cr4_guest_valid_bits()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/02/2018 16:09, Sergey Dyasli wrote:
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index aa0505036b..4856ad7c24 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -1699,7 +1699,7 @@ static void vmx_update_guest_cr(struct vcpu *v, 
> unsigned int cr)
>               * bits that are controlled by the hypervisor.
>               */
>              v->arch.hvm_vmx.cr4_host_mask = HVM_CR4_HOST_MASK | X86_CR4_PKE |
> -                                            ~hvm_cr4_guest_valid_bits(v, 0);
> +                                        ~hvm_cr4_guest_valid_bits(v->domain, 
> 0);

Indentation here looks fishy.  Please add some brackets around the
expression, and 0 => false.  Alternatively, reflow the expression to
have a linebreak after the =.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

>              v->arch.hvm_vmx.cr4_host_mask |= v->arch.hvm_vmx.vmx_realmode ?
>                                               X86_CR4_VME : 0;
>              v->arch.hvm_vmx.cr4_host_mask |= !hvm_paging_enabled(v) ?
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel