[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 4/5] x86/msr: update domain policy on CPUID policy changes



On 28/02/2018 16:09, Sergey Dyasli wrote:
> diff --git a/xen/include/asm-x86/msr.h b/xen/include/asm-x86/msr.h
> index 419ab6f8a7..4747572871 100644
> --- a/xen/include/asm-x86/msr.h
> +++ b/xen/include/asm-x86/msr.h
> @@ -606,6 +606,9 @@ int init_vcpu_msr_policy(struct vcpu *v);
>  int guest_rdmsr(const struct vcpu *v, uint32_t msr, uint64_t *val);
>  int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val);
>  
> +/* Update availability of per-domain MSRs based on CPUID policy */
> +void recalculate_msr_policy(struct domain *d);

Either this needs naming to be specifically the domain policy, or the
comment shouldn't specify per-domain only.  As we build up the policies,
I expect we will end up needing to tweak the vcpu policies as well.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> (with
some full stops at the end of comments, seeing as the series needs
another spin.)

> +
>  #endif /* !__ASSEMBLY__ */
>  
>  #endif /* __ASM_MSR_H */


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.