Re: [Xen-devel] [PATCH v5 2/5] x86/msr: add VMX MSRs into HVM_max domain policy

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 22/03/2018 10:14, Sergey Dyasli wrote:
> On Wed, 2018-03-21 at 20:46 +0000, Andrew Cooper wrote:
>> On 28/02/2018 16:09, Sergey Dyasli wrote:
>>> +
>>> +    dp->vmx.pinbased_ctls.allowed_0.raw = VMX_PINBASED_CTLS_DEFAULT1;
>>> +    dp->vmx.pinbased_ctls.allowed_1.raw = VMX_PINBASED_CTLS_DEFAULT1;
>>> +    supported = PIN_BASED_EXT_INTR_MASK |
>>> +                PIN_BASED_NMI_EXITING   |
>>> +                PIN_BASED_PREEMPT_TIMER;
>> Please have a single set of brackets around the entire or statement, so
>> editors will indent new changes correctly.
> Which editors?

Any editor which can read the file annotation stating BSD style, which
results in

supported = PIN_BASED_EXT_INTR_MASK |
    PIN_BASED_NMI_EXITING |

by default.

>  My editor is doing it fine. Anyway, is this what you are
> asking for?
>
>     supported = (PIN_BASED_EXT_INTR_MASK |
>                  PIN_BASED_NMI_EXITING   |
>                  PIN_BASED_PREEMPT_TIMER);
>

Yes.  That's great thanks.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel