Re: [Xen-devel] [PATCH 3/5] libxc: Allow loading of firmware modules for HVM guest

[Anoob Soman <anoob.soman@xxxxxxxxxx>]

On 21/03/18 15:17, Wei Liu wrote:
> On Thu, Mar 15, 2018 at 05:31:51PM +0000, Anoob Soman wrote:
> >                              modlist, start_info);
> > +        for ( i = 0; i < dom->num_modules; i++ )
> > +        {
> > +            struct xc_hvm_firmware_module mod;
> > +
> > +            DOMPRINTF("Adding module %u", i);
> > +            mod.guest_addr_out =
> > +                dom->modules[i].seg.vstart;
> Shouldn't this be dom->modules[i].seg.vstart - dom->parms.virt_base?
It didn't work when guest_addr_out = seg.vstart - virt_base. I will try 
to figure out why.
> > +            mod.length =
> > +                dom->modules[i].seg.vend - dom->modules[i].seg.vstart;
> > +
> > +            add_module_to_list(dom, &mod, dom->modules[i].cmdline,
> > +                               modlist, start_info);
> > +        }
> Now that both paths of the if ... else ... structure contain the same
> code it should be lifted outside of the loop.
Sure, I can do that.

-Anoob

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel