Re: [Xen-devel] [PATCH 4/5] libxl: Load iPXE ROM from a file

[Anoob Soman <anoob.soman@xxxxxxxxxx>]

On 21/03/18 15:25, Wei Liu wrote:
> > +            LOGE(ERROR, "xc_dom_kernel_file failed");
> > +            goto out;
> > +        }
> > +        if ((ipxe_filename = libxl__ipxe_path())) {
> > +            rc = xc_dom_module_file(dom, ipxe_filename, "ipxe");
> > +            if (rc) {
> > +                LOGE(ERROR, "xc_dom_ipxe_module_file failed");
> > +                goto out;
> This is the wrong place. Being an HVM guest doesn't mean ipxe should be
> loaded. You probably need to look a few lines down and add code in
> appropriate places like when ROMBIOS is picked.
Sure, I will fix it up.

> Wei.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel