Re: [Xen-devel] [PATCH v2 for-4.11] kconfig: don't select VPCI if building a shim-only binary

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.03.18 at 17:30, <roger.pau@xxxxxxxxxx> wrote:
> Add dummy replacements for some functions used outside of the vpci
> code, and also a guard in vmsi.c to prevent vpci arch specific helpers
> from being compiled if the option is not selected.
> 
> Reported-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with one remark:

> +static inline bool __must_check vpci_process_pending(struct vcpu *v)

I don't think you really need the __must_check here; if you agree,
I'm sure this could be dropped while committing.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel