Re: [Xen-devel] [PATCH v2 for-4.11] kconfig: don't select VPCI if building a shim-only binary

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Mar 27, 2018 at 09:36:09AM -0600, Jan Beulich wrote:
> >>> On 27.03.18 at 17:30, <roger.pau@xxxxxxxxxx> wrote:
> > Add dummy replacements for some functions used outside of the vpci
> > code, and also a guard in vmsi.c to prevent vpci arch specific helpers
> > from being compiled if the option is not selected.
> > 
> > Reported-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> with one remark:
> 
> > +static inline bool __must_check vpci_process_pending(struct vcpu *v)
> 
> I don't think you really need the __must_check here; if you agree,
> I'm sure this could be dropped while committing.

I've keep the __must_check to prevent users that don't have VPCI
enabled from adding usages of vpci_process_pending that don't check
the return value, but TBH I expect people adding or changing usages of
vpci_process_pending to have VPCI enabled.

I'm fine with you removing the __must_check at commit time.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel