Re: [Xen-devel] [PATCH v8] new config option vtsc_tolerance_khz to avoid TSC emulation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.04.18 at 16:55, <olaf@xxxxxxxxx> wrote:
> Am Mon, 09 Apr 2018 08:19:53 -0600
> schrieb "Jan Beulich" <JBeulich@xxxxxxxx>:
> 
>> Is there any guarantee that old hypervisors will send this field as zero
>> (rather than some random value)? If so, I think this should be said
>> explicitly in the commit message, together with the fact that you
>> re-use padding fields.
> 
> I have to double check, but I'm sure the whole size of the struct is 
> initialized with zero. The commit message already has "Existing padding 
> fields are reused to store vtsc_khz_tolerance as u16."

It's that sentence that I've referred to - it talks about padding, but
doesn't make clear that this padding is zero at all times.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel