Re: [Xen-devel] [RFC PATCH 1/2] Add Designated Reviewer (R:) to MAINTAINERS file and add support for it in get_maintainer.pl

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Lars Kurth writes ("[RFC PATCH 1/2] Add Designated Reviewer (R:) to MAINTAINERS 
file and add support for it in get_maintainer.pl"):
> The syntax has been copied from the Linux Maintainers file. I moved the 
> following Linux
> get_maintainer.pl patches to Xen, fixing up some merge issues (and a bug).
...
>               'm!' => \$email_maintainer,
> +        'r!' => \$email_reviewer,
>               'n!' => \$email_usename,

Your text editor has some difficulty with the tabs here, resulting in
misalignment.  Set its tab width to 8 and reindent.

> +        } elsif ($ptype eq "R") {
> +        my ($name, $address) = parse_email($pvalue);
> +        if ($name eq "") {
> +            if ($i > 0) {
> +            my $tv = $typevalue[$i - 1];
> +            if ($tv =~ m/^([A-Z]):\s*(.*)/) {
> +                if ($1 eq "P") {
> +                $name = $2;
> +                $pvalue = format_email($name, $address, $email_usename);
> +                }
> +            }
> +            }
> +        }

What on earth is all this    if ($name eq "")  stuff doing ?  Is it
appropriate in this case ?

If it is actually needed, you should probably not just cut and paste
it.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel