Re: [Xen-devel] [Qemu-devel] [PATCH v7 00/16] xen: xen-domid-restrict improvements

[no-reply@xxxxxxxxxxx]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1524156319-11465-1-git-send-email-ian.jackson@xxxxxxxxxxxxx
Subject: [Qemu-devel] [PATCH v7 00/16] xen: xen-domid-restrict improvements

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               
patchew/1524156319-11465-1-git-send-email-ian.jackson@xxxxxxxxxxxxx -> 
patchew/1524156319-11465-1-git-send-email-ian.jackson@xxxxxxxxxxxxx
Switched to a new branch 'test'
791deba00b configure: do_compiler: Dump some extra info under bash
b10a749616 os-posix: cleanup: Replace perror with error_report
f6ee193e03 os-posix: cleanup: Replace fprintf with error_report in remaining 
call sites
38a44ba872 xen: Expect xenstore write to fail when restricted
4862292c1d xen: Remove now-obsolete xen_xc_domain_add_to_physmap
9a713e3565 xen: Use newly added dmops for mapping VGA memory
75ebbfeb30 os-posix: Provide new -runas <uid>:<gid> facility
013cb70cd4 os-posix: cleanup: Replace fprintfs with error_report in 
change_process_uid
581e476008 xen: destroy_hvm_domain: Try xendevicemodel_shutdown
e13e890b93 xen: move xc_interface compatibility fallback further up the file
daeeb16831 xen: destroy_hvm_domain: Move reason into a variable
9b037ca2ab xen: defer call to xen_restrict until just before os_setup_post
59764a2887 xen: restrict: use xentoolcore_restrict_all
11c13929a6 xen: link against xentoolcore
4fbbd8e7d6 AccelClass: Introduce accel_setup_post
e572031cba checkpatch: Add xendevicemodel_handle to the list of types

=== OUTPUT BEGIN ===
Checking PATCH 1/16: checkpatch: Add xendevicemodel_handle to the list of 
types...
Checking PATCH 2/16: AccelClass: Introduce accel_setup_post...
Checking PATCH 3/16: xen: link against xentoolcore...
Checking PATCH 4/16: xen: restrict: use xentoolcore_restrict_all...
Checking PATCH 5/16: xen: defer call to xen_restrict until just before 
os_setup_post...
Checking PATCH 6/16: xen: destroy_hvm_domain: Move reason into a variable...
Checking PATCH 7/16: xen: move xc_interface compatibility fallback further up 
the file...
Checking PATCH 8/16: xen: destroy_hvm_domain: Try xendevicemodel_shutdown...
Checking PATCH 9/16: os-posix: cleanup: Replace fprintfs with error_report in 
change_process_uid...
Checking PATCH 10/16: os-posix: Provide new -runas <uid>:<gid> facility...
Checking PATCH 11/16: xen: Use newly added dmops for mapping VGA memory...
Checking PATCH 12/16: xen: Remove now-obsolete xen_xc_domain_add_to_physmap...
Checking PATCH 13/16: xen: Expect xenstore write to fail when restricted...
Checking PATCH 14/16: os-posix: cleanup: Replace fprintf with error_report in 
remaining call sites...
ERROR: Error messages should not contain newlines
#23: FILE: os-posix.c:132:
+    error_report("Change of process name not supported by your OS\n");

total: 1 errors, 0 warnings, 16 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 15/16: os-posix: cleanup: Replace perror with error_report...
Checking PATCH 16/16: configure: do_compiler: Dump some extra info under bash...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@xxxxxxxxxx
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel