[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] shim: don't let build modify shim.config

On 19/04/18 18:14, Andrew Cooper wrote:
> On 19/04/18 15:54, Wei Liu wrote:
>> On Thu, Apr 19, 2018 at 01:01:53PM +0200, Juergen Gross wrote:
>>> On 19/04/18 12:47, Jan Beulich wrote:
>>>>>>> On 19.04.18 at 12:30, <jgross@xxxxxxxx> wrote:
>>>>> --- a/tools/firmware/xen-dir/Makefile
>>>>> +++ b/tools/firmware/xen-dir/Makefile
>>>>> @@ -41,21 +41,22 @@ linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES) FORCE
>>>>>  $(D): linkfarm.stamp
>>>>>   $(MAKE) -C $(D)/xen distclean
>>>>> -.PHONY: shim-%config
>>>>> -shim-%config: $(D) FORCE
>>>>> - $(MAKE) -C $(D)/xen $*config \
>>>> I think there was a reason for the % and $*.
>>> The only one I could think of is the possibility to do
>>> make shim-defaultconfig
>>> or similar calls. Question is who will ever need that. In case it is
>>> believed to be valuable I can keep it.
>> Not likely I think.
> Using `make shim-menuconfig` was a specific usecase for my original
> version, but with this difference in representation, the usecase has
> mostly gone away.
> With this change in place, what is the expected workflow for making an
> update to the configuration?

You can still cd to tools/firmware/xen-dir/xen-root/xen and do the
"make menuconfig" there. Afterwards copy the resulting .config to
../../shim.config and you have the same result. Question is whether
you want to do that in case we are stripping down shim.config later.

Above assumes V2 of my patch will be taken, of course.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.