Re: [Xen-devel] [RFC PATCH 2/8] x86/vlapic: use apic_id array to set initial (x2)APIC ID

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.01.18 at 05:01, <chao.gao@xxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/hvm/domain.h
> +++ b/xen/include/asm-x86/hvm/domain.h
> @@ -213,6 +213,9 @@ struct hvm_domain {
>      uint8_t thread_per_core;
>  };
>  
> +#define hvm_vcpu_x2apic_id(v) 
> (v->domain->arch.hvm_domain.apic_id[v->vcpu_id])

I can't seem to find where you set up this array.

> +#define hvm_vcpu_apic_id(v) (hvm_vcpu_x2apic_id(v) % 255)

I don't think the % 255 is appropriate here - the macro simply shouldn't be
invoked in such a case.

On the whole I'm not convinced using a array is appropriate - calculating
the APIC ID should be very involved, and require much less than possibly
multiple kb of storage.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel