Re: [Xen-devel] [PATCH RFC 02/10] passthrough: split out x86 PCI code to x86/pci.c

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 04/23/2018 04:34 PM, Jan Beulich wrote:
> > > > On 21.02.18 at 22:46, <wei.liu2@xxxxxxxxxx> wrote:
> > Move the functions that reference x86 hvm data structures to its own
> > file.  Rename pci_clean_dpci_irqs to arch_pci_clean_irqs.
> >
> > There is still one location in that file which references
> > arch.hvm_domain, but it is fine because ARM guest is HVM.
> >
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > Cc: Julien Grall <julien.grall@xxxxxxx>
> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >
> > ARM doesn't select HAS_PCI, that's why ARM build is not broken by
> > this. AIUI ARM will select HAS_PCI at some point, hence I only move
> > the x86 bits.
> The fact that this change doesn't actually affect ARM is again an
> indication that the decision whether the code you move here is
> x86-specific depends on what parts of PCI pass-through ARM is
> actually going to want to (re-)use. I'd again prefer to take that
> decision either when ARM actually implements that, or based on
> the ARM folks clearly foreseeing that this code is not coming
> close to anything they may want use.
I can't see any use of that code on Arm. There are potential to move 
x86-ism outside, but this patch is already a good start.
I already gave my acked-by on a separate e-mail.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel