Re: [Xen-devel] [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

[Lars Kurth <lars.kurth@xxxxxxxxxx>]

On 30/04/2018, 15:36, "Ian Jackson" <ian.jackson@xxxxxxxxxx> wrote:

    > +if (! -e $get_maintainer) {
    > +    die "$tool: The tool requires $get_maintainer\n";
    > +}
    
    You may remember me saying I wanted a mode that simply transfers
    maintainer information already provided in the patches.  That is
    useful when the CCs have been manually specified.
    
    I don't think such a mode is essential for me to ack this patch.

I think I may have misunderstood you.

Given that git send-email reads CC's anywhere in the body of a *.patch file, 
I am not sure why this is useful. Can you enlighten me? It does also have all 
the bits to ensure that I can do this. Aka I can make sure that all the CC's 
from 
the commit-message/*.patch files are added to the e-mail block. Right now
I avoid duplication: aka I only add stuff to the header if it is not already 
In the commit-message/*.patch.  

I can see though, that some of the tool functionality is useful in non-xen 
trees. Thus, changing it such that it doesn't fall over when get_maintainers.pl 
isn't there is probably a good idea.

Lars  

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel