[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

Lars Kurth writes ("Re: [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl 
script to optimise the workflow when using git format-patch with 
> Given that git send-email reads CC's anywhere in the body of a *.patch file, 
> I am not sure why this is useful. Can you enlighten me? It does also have all 
> the bits to ensure that I can do this. Aka I can make sure that all the CC's 
> from 
> the commit-message/*.patch files are added to the e-mail block. Right now
> I avoid duplication: aka I only add stuff to the header if it is not already 
> In the commit-message/*.patch.  
> I can see though, that some of the tool functionality is useful in non-xen 
> trees. Thus, changing it such that it doesn't fall over when 
> get_maintainers.pl 
> isn't there is probably a good idea.

The function of your tool is to invoke get_maintainer and put the
addresses from there everywhere appropriate including, in particular,
the CCs of the cover letter.

The only reason your tool is needed is because there is no other tool
that gets the cover letter right.

But I often have a set of patches where I have manually decided who
they should be CCd to, and put appropriate tags in my commit
messages.  I don't blindly use get_maintainer.

When I do this, there is nothing that gets the CC for the cover letter
right.  (I sometimes bodge it.)  Your tool already knows how to
extract CCs from the individual non-cover-letter patches and add them
to the cover letter.  That is the function I want - to do that, but
not run get_maintainer.

Nor do I need, I think, your tool to edit any of the non-cover-letter
patches, since git-send-email will find CCs in their bodies and use
them for the email recipients.

I don't think I really mind where the CCs end up in the cover letter
(whether they are in the body, or just in the email header), but
others have made a convincing argument that they should be in the
body, so that is fine.

Does that make sense ?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.