Re: [Xen-devel] [PATCH] xen: Add RING_COPY_RESPONSE()

[Juergen Gross <jgross@xxxxxxxx>]

On 03/05/18 01:45, Marek Marczykowski wrote:
> On Wed, May 02, 2018 at 01:20:09AM -0600, Jan Beulich wrote:
>>>>> On 30.04.18 at 23:54, <marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote:
>>> Using RING_GET_RESPONSE() on a shared ring is easy to use incorrectly
>>> (i.e., by not considering that the other end may alter the data in the
>>> shared ring while it is being inspected).  Safe usage of a response
>>> generally requires taking a local copy.
>>>
>>> Provide a RING_COPY_RESPONSE() macro to use instead of
>>> RING_GET_RESPONSE() and an open-coded memcpy().  This takes care of
>>> ensuring that the copy is done correctly regardless of any possible
>>> compiler optimizations.
>>>
>>> Use a volatile source to prevent the compiler from reordering or
>>> omitting the copy.
>>>
>>> This is complementary to XSA155.
>>>
>>> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>>
>> Please don't forget to Cc maintainers of files you change.
> 
> According to MAINTAINERS, Konrad is the only one responsible for this
> file (PUBLIC I/O INTERFACES AND PV DRIVERS DESIGNS). I have plugged
> get_maintainer.pl to my git send-email, so this is automated.
> Is anyone missing there?

Konrad maybe?


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel