Re: [Xen-devel] [PATCH] x86/domain: Drop the only-written smap_check_policy infrastructure

[George Dunlap <dunlapg@xxxxxxxxx>]

On Tue, May 8, 2018 at 2:03 PM, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> c/s 4c5d78a10d "x86/pagewalk: Re-implement the pagetable walker" dropped the
> consumer of smap_policy.  Looking at c/s 31ae587e6f which introduced the
> smap_check logic, it exists only to work around a bug in guest_walk_tables()
> was resolved by the aformentioned commit.
>
> Remove the unused variables and associated infrastructure.
>
> Reported-by: Jason Andryuk <jandryuk@xxxxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Juergen Gross <jgross@xxxxxxxx>
> CC: Jason Andryuk <jandryuk@xxxxxxxxx>
>
> I'm on the fence as to whether to suggest this for 4.11 at this point.  Its
> probably not something to be backported, but it is a nice bit of cleanup, and
> removes a particularly gross hack.

It looks like the commit that made this code vestigal was introduced
in March 2017?  So we've already had two releases with this flag not
doing anything, and no ill effects reported.

I'd be in favor of accepting a patch like this for 4.11, and also for
backporting it to 4.10 and 4.9

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel