Re: [Xen-devel] [PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer

[Juergen Gross <jgross@xxxxxxxx>]

On 17/05/18 07:29, Oleksandr Andrushchenko wrote:
> On 05/17/2018 07:28 AM, Juergen Gross wrote:
>> On 16/05/18 06:59, Oleksandr Andrushchenko wrote:
>>> On 05/11/2018 06:15 PM, Juergen Gross wrote:
>>>> On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote:
>>>>> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote:
>>>>>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko
>>>>>> wrote:
>>>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>>>>>>
>>>>>>> Add missing string constants for {feature|request}-raw-pointer
>>>>>>> to align with the rest of the interface file.
>>>>>>>
>>>>>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and
>>>>>>> "request-raw-pointer")
>>>>>>>
>>>>>>> Signed-off-by: Oleksandr Andrushchenko
>>>>>>> <oleksandr_andrushchenko@xxxxxxxx>
>>>>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>>>>> Juergen, you OK with an release-ack?
>>>> Yes:
>>>>
>>>> Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
>>> Is this ack for both patches or this one only?
>> It was meant for patch 1 only.
> Clear
>>> I see Konrad has applied this patch, but
>>> "[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard
>>> and pointer"
>>> is still floating.
>> In principle I'm fine with taking it for 4.11, but I think at this stage
>> of the release there should be a formal request to include it.
> ...and the request should come from Konrad?
> Or who else may request that?

Normally the sender of the patch would make this request below the ---
of the commit message, e.g.:
  ---
  This patch should go into 4.11 as it is needed for a related Linux
  kernel patch and the risk is next to zero for Xen due to only adding
  some macros not in use on Xen side.

The request can be made by anyone, of course, e.g. by replying to the
patch mail and including the release manager as a recipient.

> And, as I have r-b's from Konrad for both patches,
> will it be ok if we apply the corresponding changes to the
> kernel now, so my change to xen-kbdfront is unblocked?

No, please don't do that.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel