Re: [Xen-devel] [PATCH 3/6] arm: make it possible to disable the SMMU driver

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Stefano Stabellini <sstabellini@xxxxxxxxxx> 05/21/18 10:35 PM >>>
>On Tue, 24 Apr 2018, Julien Grall wrote:
>> On 04/20/2018 10:39 AM, Jan Beulich wrote:
>> > > > > On 19.04.18 at 17:44, <julien.grall@xxxxxxx> wrote:
>> > > On 18/04/18 23:15, Stefano Stabellini wrote:
>> > > > --- a/xen/drivers/passthrough/Kconfig
>> > > > +++ b/xen/drivers/passthrough/Kconfig
>> > > > @@ -1,3 +1,5 @@
>> > > >       config HAS_PASSTHROUGH
>> > > >        bool
>> > > > +
>> > > > +source "drivers/passthrough/arm/Kconfig"
>> > > 
>> > > Can't we load arm/Kconfig only when arm is selected? This would avoid
>> > > weird option on x86.
>> > 
>> > How would those options appear for x86, given ...
>> > 
>> > > > --- /dev/null
>> > > > +++ b/xen/drivers/passthrough/arm/Kconfig
>> > > > @@ -0,0 +1,7 @@
>> > > > +
>> > > > +config HAS_SMMUv2
>> > > > +    bool "ARM SMMUv2 driver"
>> > > > +    default y
>> > > > +    depends on ARM
>> > 
>> > ... this "depends on"? Of course if more options are going to appear here,
>> > wrapping the whole file in "if ARM" would be useful anyway, even if only
>> > to limit redundancy.
>
>Sorry, I think I am misunderstanding your suggestion. If you are
>suggesting:
>
>#if ARM
>config HAS_SMMUv2
>bool "ARM SMMUv2 driver"
>default y
>depends on ARM
>#endif
>
>then, this won't work because we are not running the kconfig files
>through the preprocessor.

if ARM
config HAS_SMMUv2
bool "ARM SMMUv2 driver"
default y
endif

The "if" basically adds a respective "depends on" for all enclosed options.


Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel