[Xen-devel] [PATCH v2 6/6] tools: --with-system-{ovmf, seabios, ipxe} should provide absolute paths

[Wei Liu <wei.liu2@xxxxxxxxxx>]

The paths shouldn't be set to "yes".

Reported-by: Anthony Perard <anthony.perard@xxxxxxxxxx>
Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
---
Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

new in v2
---
 tools/configure    | 3 +++
 tools/configure.ac | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/tools/configure b/tools/configure
index 16960a425b..b40d6646fb 100755
--- a/tools/configure
+++ b/tools/configure
@@ -4564,6 +4564,7 @@ if test "${with_system_seabios+set}" = set; then :
     seabios=n
     case $withval in
         no) seabios_path= ;;
+        yes) as_fn_error $? "Seabios specified, but is not an absolute path" 
"$LINENO" 5 ;;
         *)  seabios_path=$withval ;;
     esac
 
@@ -4587,6 +4588,7 @@ if test "${with_system_ovmf+set}" = set; then :
     ovmf=n
     case $withval in
         no) ovmf_path= ;;
+        yes) as_fn_error $? "OVMF specified, but is not an absolute path" 
"$LINENO" 5 ;;
         *)  ovmf_path=$withval ;;
     esac
 
@@ -4610,6 +4612,7 @@ if test "${with_system_ipxe+set}" = set; then :
     ipxe=n
     case $withval in
         no) ipxe_path= ;;
+        yes) as_fn_error $? "IPXE specified, but is not an absolute path" 
"$LINENO" 5 ;;
         *)  ipxe_path=$withval ;;
     esac
 
diff --git a/tools/configure.ac b/tools/configure.ac
index 8e4b173d6f..aae7786ed7 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -216,6 +216,7 @@ AC_ARG_WITH([system-seabios],
     seabios=n
     case $withval in
         no) seabios_path= ;;
+        yes) AC_MSG_ERROR([Seabios specified, but is not an absolute path]) ;;
         *)  seabios_path=$withval ;;
     esac
 ],[])
@@ -233,6 +234,7 @@ AC_ARG_WITH([system-ovmf],
     ovmf=n
     case $withval in
         no) ovmf_path= ;;
+        yes) AC_MSG_ERROR([OVMF specified, but is not an absolute path]) ;;
         *)  ovmf_path=$withval ;;
     esac
 ],[])
@@ -250,6 +252,7 @@ AC_ARG_WITH([system-ipxe],
     ipxe=n
     case $withval in
         no) ipxe_path= ;;
+        yes) AC_MSG_ERROR([IPXE specified, but is not an absolute path]) ;;
         *)  ipxe_path=$withval ;;
     esac
 ],[])
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel