[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 6/6] tools: --with-system-{ovmf, seabios, ipxe} should provide absolute paths



On Mon, Jun 25, 2018 at 06:21:06PM +0200, Roger Pau Monné wrote:
> On Mon, Jun 25, 2018 at 12:35:33PM +0100, Wei Liu wrote:
> > The paths shouldn't be set to "yes".
> 
> If you want to check if an absolute path is provided I would rather
> do:
> 
> case $withval in
>     no) ovmf_path= ;;
>     /*) ovmf_path=$withval ;;
>     *)  AC_MSG_ERROR([OVMF specified, but is not an absolute path]) ;;
> esac
> 
> The path would still allow anything else apart from 'yes' to still be
> considered and absolute path.

Right, /* is better.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.