[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 02/13] libx86: Introduce libx86/cpuid.h

>>> On 16.07.18 at 12:22, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 16/07/18 10:23, Jan Beulich wrote:
>>>>> On 13.07.18 at 22:03, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> Begin to untangle the header dependency tangle by moving definition of
>>> struct cpuid_leaf out of x86_emulate.h into the new cpuid.h.
>>> Additionally, plumb the header through to libxc.  This is technically a
>>> redundant include at this point, but it helps build-test the later changes,
>>> and will be used eventually.
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>> Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>>> ---
>>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>> CC: Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>
>>> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
>>> Note concerning the positioning of libx86.  It turns out after trying to 
>>> move
>>> it elsewhere that the movement is prohibitive because of the way Xen headers
>>> are included by the tools.
>> If there's really something preventing it to be placed better, then I'm
>> certainly willing to give my ack here, but I'd like to have a more clear
>> understanding of what issue(s) you are talking about above.
> It is better explained in the context of the following patch.
> Moving to asm-x86/libx86/ breaks the autogen safety because the entire
> tree hierarchy is made available with a single directory symlink.

But there was never talk of asm-x86/libx86/. Options discussed
were top level lib/x86/ and include/x86/, or xen/lib/x86/ and
xen/include/libx86/ (or close derivatives thereof).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.