Re: [Xen-devel] [PATCH v4 9/9] osstest: add FreeBSD Xen build job

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Jul 18, 2018 at 04:18:05PM +0100, Ian Jackson wrote:
> Ian Jackson writes ("Re: [PATCH v4 9/9] osstest: add FreeBSD Xen build job"):
> > Roger Pau Monne writes ("[PATCH v4 9/9] osstest: add FreeBSD Xen build 
> > job"):
> > > To both the FreeBSD and the xen-unstable flights.
> > 
> > Please add this to the osstest flights too!
> 
> I should expand on this:
> 
> The reason you want the osstest branch to be covered is that it is an
> input to this job.  There is no protection against an un-covered input
> branches introducing a regression.

I'm attaching a patch below that adds a FreeBSD Xen build job to the
osstest flights. I've also pushed the updated branch to my git repo:

git://xenbits.xen.org/people/royger/osstest.git freebsd_improvement_v5

> Looking at the runvars, the declared inputs are:
> 
> +freebsd-master build-amd64-xen-freebsd     freebsdbuildjob    
> build-amd64-freebsd
> +freebsd-master build-amd64-xen-freebsd     revision_minios
> +freebsd-master build-amd64-xen-freebsd     revision_ovmf
> +freebsd-master build-amd64-xen-freebsd     revision_qemu
> +freebsd-master build-amd64-xen-freebsd     revision_qemuu     
> ap-fetch-version-baseline:qemu-upstream-unstable
> +freebsd-master build-amd64-xen-freebsd     revision_seabios
> +freebsd-master build-amd64-xen-freebsd     revision_xen       
> ap-fetch-version-baseline:xen-unstable
> 
> Do you know what proportion of these are actually used by the FreeBSD
> Xen build ?  All that are need this job adding to their own flights.

minios, ovmf and qemu is not used. I plan to add support for ovmf, but
the rest (specially qemu-trad) will likely remain unused.

Thanks, Roger.

---8<---
From b67d5d562e1be182bb09b557d73ad3a9d1494690 Mon Sep 17 00:00:00 2001
From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
Date: Wed, 18 Jul 2018 17:49:40 +0200
Subject: [PATCH] osstest: add a FreeBSD Xen build job to osstest flights
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The runvar diff is the following:

+osstest build-amd64-xen-freebsd     all_host_os        freebsd
+osstest build-amd64-xen-xsm-freebsd all_host_os        freebsd
+osstest build-amd64-xen-freebsd     all_hostflags      
PropEq:Firmware:bios:bios
+osstest build-amd64-xen-xsm-freebsd all_hostflags      
PropEq:Firmware:bios:bios
+osstest build-amd64-xen-freebsd     arch               amd64
+osstest build-amd64-xen-xsm-freebsd arch               amd64
+osstest build-amd64-xen-freebsd     build_lvextend_max 50
+osstest build-amd64-xen-xsm-freebsd build_lvextend_max 50
+osstest build-amd64-xen-freebsd     enable_livepatch   true
+osstest build-amd64-xen-xsm-freebsd enable_livepatch   true
+osstest build-amd64-xen-freebsd     enable_ovmf        false
+osstest build-amd64-xen-xsm-freebsd enable_ovmf        false
+osstest build-amd64-xen-freebsd     enable_xend        false
+osstest build-amd64-xen-xsm-freebsd enable_xend        false
+osstest build-amd64-xen-freebsd     enable_xsm         false
+osstest build-amd64-xen-xsm-freebsd enable_xsm         true
+osstest build-amd64-xen-freebsd     host_hostflags     arch-amd64,purpose-build
+osstest build-amd64-xen-xsm-freebsd host_hostflags     arch-amd64,purpose-build
+osstest build-amd64-xen-freebsd     revision_minios
+osstest build-amd64-xen-xsm-freebsd revision_minios
+osstest build-amd64-xen-freebsd     revision_ovmf
+osstest build-amd64-xen-xsm-freebsd revision_ovmf
+osstest build-amd64-xen-freebsd     revision_qemu
+osstest build-amd64-xen-xsm-freebsd revision_qemu
+osstest build-amd64-xen-freebsd     revision_qemuu     
ap-fetch-version-baseline:qemu-upstream-unstable
+osstest build-amd64-xen-xsm-freebsd revision_qemuu     
ap-fetch-version-baseline:qemu-upstream-unstable
+osstest build-amd64-xen-freebsd     revision_seabios
+osstest build-amd64-xen-xsm-freebsd revision_seabios
+osstest build-amd64-xen-freebsd     revision_xen       
ap-fetch-version-baseline:xen-unstable
+osstest build-amd64-xen-xsm-freebsd revision_xen       
ap-fetch-version-baseline:xen-unstable
+osstest build-amd64-xen-freebsd     tree_minios
+osstest build-amd64-xen-xsm-freebsd tree_minios
+osstest build-amd64-xen-freebsd     tree_ovmf
+osstest build-amd64-xen-xsm-freebsd tree_ovmf
+osstest build-amd64-xen-freebsd     tree_qemu          
git://xenbits.xen.org/qemu-xen-traditional.git
+osstest build-amd64-xen-xsm-freebsd tree_qemu          
git://xenbits.xen.org/qemu-xen-traditional.git
+osstest build-amd64-xen-freebsd     tree_qemuu         
git://xenbits.xen.org/qemu-xen.git
+osstest build-amd64-xen-xsm-freebsd tree_qemuu         
git://xenbits.xen.org/qemu-xen.git
+osstest build-amd64-xen-freebsd     tree_seabios
+osstest build-amd64-xen-xsm-freebsd tree_seabios
+osstest build-amd64-xen-freebsd     tree_xen           
git://xenbits.xen.org/xen.git
+osstest build-amd64-xen-xsm-freebsd tree_xen           
git://xenbits.xen.org/xen.git

Suggested-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
 mfi-common | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mfi-common b/mfi-common
index 614d3c10..ae6a337d 100644
--- a/mfi-common
+++ b/mfi-common
@@ -326,7 +326,7 @@ create_build_jobs () {
 
     # Only add FreeBSD Xen buildjobs to the xen-* branches at the moment.
     case "$branch" in
-    xen-*)
+    xen-*|osstest)
       case "$xenbranch" in
       xen-3.*-testing)  build_on_freebsd=false;;
       xen-4.?-testing)  build_on_freebsd=false;;
-- 
2.18.0



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel