Re: [Xen-devel] [PATCH 03/16] x86/HVM: switch virtual_intr_delivery_enabled() hook to simple boolean

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Thursday, July 19, 2018 2:16 PM
> 
> >>> On 19.07.18 at 03:56, <kevin.tian@xxxxxxxxx> wrote:
> >>  From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> >> Sent: Wednesday, July 11, 2018 9:25 PM
> >>
> >> From: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> >>
> >> This patch modifies the hvm_funcs.virtual_intr_delivery_enabled()
> >> to become a bool variable as VMX does and SVM will simply return a
> >> static value.
> >>
> >> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >> ---
> >> Extracted from an SVM/AVIC series patch.
> >>
> >> --- a/xen/arch/x86/hvm/vlapic.c
> >> +++ b/xen/arch/x86/hvm/vlapic.c
> >> @@ -1258,14 +1258,6 @@ void vlapic_adjust_i8259_target(struct d
> >>      pt_adjust_global_vcpu_target(v);
> >>  }
> >>
> >> -int vlapic_virtual_intr_delivery_enabled(void)
> >> -{
> >> -    if ( hvm_funcs.virtual_intr_delivery_enabled )
> >> -        return hvm_funcs.virtual_intr_delivery_enabled();
> >> -    else
> >> -        return 0;
> >> -}
> >> -
> >>  int vlapic_has_pending_irq(struct vcpu *v)
> >>  {
> >>      struct vlapic *vlapic = vcpu_vlapic(v);
> >> @@ -1278,7 +1270,7 @@ int vlapic_has_pending_irq(struct vcpu *
> >>      if ( irr == -1 )
> >>          return -1;
> >>
> >> -    if ( vlapic_virtual_intr_delivery_enabled() &&
> >> +    if ( hvm_funcs.virtual_intr_delivery_enabled &&
> >>           !nestedhvm_vcpu_in_guestmode(v) )
> >>          return irr;
> >>
> >
> > above is another functional change. Can you explain and if making sense
> > then put the fix in separate patch?
> 
> I'm afraid I don't understand: What functional change? All the patch
> does is change from a hook based approach to a flag based one, as
> said in the description.
> 

forget it. I don't know why I thought nestedhvm check was added by your
patch. :/

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

Thanks
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel