[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [RFC PATCH 09/17] libxl: use \x1b to separate qemu arguments for linux stubdomain
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>
- From: Simon Gaiser <simon@xxxxxxxxxxxxxxxxxxxxxx>
- Date: Thu, 2 Aug 2018 03:54:40 +0200
- Autocrypt: addr=simon@xxxxxxxxxxxxxxxxxxxxxx; prefer-encrypt=mutual; keydata= mQINBFoNGgoBEADpL5fWdBgpH67IYAGPQl0jSevtBzQnjgbiNXu72FfG1Emji2l+mXmHlzxL LnRH+9OyDaOR7tUCbg+iqdbcTowDeFOYUaKQ1+Ub6QiZoi/xZyYlWEGbEc+7grLv1h8ZCt05 Jcp8F73p+ZQhmbT04hhxs4fQ5lsU8T9WJsG4GzF2RKGUbdAk+v/vgu7RFP2bCpqGCv5tAv1x b0geXt4GGNtVqQowDG+1kTnYPousAY2RlexBAjxg5FqM1bliLak8TcoswF7PUhOf8XvqyhI7 H4oySBHUDIyYsreHW64LNqWRK5pFTfqaWssxUyTF8U8Ms8QVNFGyRUWA+erwiv36y8c2McN4 RD7UIZu1x98MbyjqhUcNJj8sNyekDCsClBwKp40aOVjIdvcFZO74M+/SY+5/EUckc1G0+95O J7ZmHU5uEIyovrQvQR9Pypr6NB63OHNXwdfxTPDCnR3vC3r5yNv1+rvrIujO03yWatC5WOGt gGMTwJcbH3tMr354F21p3v/1do3pP88ox279OnbZifnyRyvT6aTo9dFROcG+w4+E4D2sQpwZ lYGbq3Y9f9eQRnBxT/exli8EAcpe5vU7xOjtBFADXN0UDZZajOaNGHtA5o+sFoL6BhKJjuob dNlXtw1zaTJJzCU8k3pZ7xwLsQEVF71KqTN6aGrioG/8S0ZbqwARAQABtDtTaW1vbiBHYWlz ZXIgKElUTCBlbWFpbCBrZXkpIDxzaW1vbkBpbnZpc2libGV0aGluZ3NsYWIuY29tPokCSQQT AQoAMxYhBELmYkepYOm8Nih8D/4aF85p0NysBQJaDRoKAhsBBAsJCAcEFQoJCAIWAAIeAQIX gAAKCRD+GhfOadDcrE8VD/9IPOZcZjPTZkFs7eiqFocr7Ueu/rjy9mJvuZRtQCK2vexNd97z SrPLyKibv/CgpI3Oki2wGrKizgQW4uGDSBd+DDCLaxGmR1PEwPFbwzjEhST1ci/W8IsEsOjG xLe1hcv2U1mtR/WAvjrZcKUs1TGimXuK2u/8OBp+m0xKMUsy30AmyINPtB9LJQSOGqJBOnBc LrK8fGLAIrcVIQyoYiZQKXRFYx4SMCAgOy3Fqh/J2FZfyJXH94HjIXYeOT0t11jD/6vxh5k0 UGP/bDmAWpnHK328BytPlZnf++N+FPfUDyTR1WzFqxHKj5J0YTV0JTA9v0MnvqI71xpb6U9q rZy/yw0FRAe8TJlgoqDbgEDF7+9xM3yJc+1QP4OFs8T65c3xOXTysbRQUzdFnUicSrwj8www QDBlttl1uJnvrHwArJ74pGe2abs8635ABX8SPVxAnUD242Kl71E+C9aCP+XFBPF9rsVPi3YX dq5JzHAOzWHCpCRVelqpkR0ykXm7b6jr+dJ9I0Gs9rOlKisa+GPmyQUzd7XGUO/GW3W8U0pj FUTcMJ+jpjb/UFVpiUIbds0w6emDGZsY9ra/iQSAzFZi9QJR+a88tdeySC1GA2I+UZSbwaKx pqgcXsacRyjR9ph8mGriCU4BMEqoli16pvS4kolMOp9S8KQnh02qX6+7z7kCDQRaDRpEARAA zVDRdV7XDo3M5nGVJYBFqC+vwpRwYOb0BU2IeCuKlH3no9jYSkxPSokN3GEn6bohxvK+nyvS 7b99i2byiGvmg4oRFOUAesHgVAxKpCP9Eerov67Coh/DDBM4hV2d+ZEttQsMQVOnHDLyQGCN 2oVKhenjb53IEaZi0MeyU+wzWhZExGxFAzRL9vJ8X+u1Nw7f+zlWncWEandVZxY6zjmaav21 yJtAvMEuFI+PPYxPMQzKn6gP6XPwf/9chE2VRmguBaLoG0JRNKJ5NSLfYMu9C0A52enWAXJy TwzQ/83DA7W5JXnCjyw6HHA6h3FNW81ASljxHmsOYtcb8J7hAPiFp5Z765jL2loUvbNTncwB mRceX7eQRYNcp6VblvPY68Du5sKx0reHk+ZYmcMa35KBMd3GuXL8dr/onpQpXWiSWyBK0aEC HUippHMiabjeMZ8oTYfq+sXi4jTcQ5h0ThOPG2RMtswlY67xJi1wExIJfp9AflCklUs73Uqg vRksaut+SDGmrYNJBUUkENVvijt1iHJJZJlbWN99bG7KF6pPbj7p+ZHSBTUj53skzDjWdgq1 xuaIv5woZtaRpdggNT/ah4jOEwgLaDtNjsffjIlM/l2+26xxo9sbo8PboZYmrI4vcSO+IXKY 6e7rAz/PTJF/3ITH45sQNQrpYrvRN2dalnkAEQEAAYkEbAQYAQoAIBYhBELmYkepYOm8Nih8 D/4aF85p0NysBQJaDRpEAhsCAkAJEP4aF85p0NyswXQgBBkBCgAdFiEE3E8ezGzG3N1CTQ// kO9xfO/xly8FAloNGkQACgkQkO9xfO/xly9PMw//U+Nu/7rcJ4X3ed7h7AGpAEKWTecs9OWJ IfjzJoE3w2ZAUvhEByT5kXG0cbT44/FGVdp54kQtH2g/ETpIXEfkYGJisEQAwlU93D74wZa5 +5u8RnbyaOyR7bNFOEOngbtyKZohZlJ3AdA++YRunrNUO3TATgGlTgVSlmg9f1+pURcod491 dTDbOIUibQphrTYefdKXt+l5Icx6FfyRDqFgBsm8hRr5fj5h2dGGXvB5Rs/Q/Mhy2ma2a0pY 7w95t6KO7ZWOQsHOUk7eoJKvU04yV1MPDZic+b4VUb2vIZ/qze2eLShf3LoH/4KsNdMPQ0kv 3OY8cjYhHXNyyLo+BWDJ3yFn8fjt6SViE217GfAM5HvV51hQUZEUBrkRSKLTB4yeA/zMNDCR wJRUDFLCZuQfWU0hmQJ2appqmlikgJDBvUVgBUg1GzTI0vGxs1X1Go01fBvIXk2nPLMoVrqs vV6iJPAVZQ2MWAM5koM58APwUG4nj5XKWcMuz31V3IqUKLZ7XE3uqTPcLUPbr53o64/xeQ5z vL5d7uzLkyhQKNH3h7LysG9gi7nj3cAfMlbX/ameBTOsP7SE8j4bJA6BmpQ4UF1tr8uO7xDy cpLWbfV4ocQrN12xVnaAlGNWI4bQfAleCJEn7F96THWQSslA+u/rTvI/IizKCLuu2+gnispT uajXPxAAvwXraqyw/mlQe+sEJip+ivgJ5jOtT+RY2z5fTja9T9k/vADcuXowJN0TP3w82rz6 JG0LSD1OGiRUTqk8TYXYdOdkBU7rFI5MMoi7SbtF2S9B7urqTRbAOYrqMu2jzzhFonJ0yGFS kelooiRf77gFqJx5IuBGPVTzPkr/YhhrgNDo79sYGusnaae/5VjpF2JWiN338jBtxbieNRpb zVf31PbeNCqAcc324RXSZ5AtxEGszyC9I/OMonCTnXAX02TbyN8hcNIAfWBkV4lmFI+LKo8v PwxIjbza1b9KHybp4y1pIunG+xhPdxARmeyLUM7JTAgap3gHG3kCdiDpiVLCcUEkrrmRxshI sToCsQHJyLwp87ECSc9HXKMLETSiyzbn4QJkIt7DnZR5kAg4PQBEnWeL7dys4TYO6ymslFaw RkowIqcDXU6cO1k9qwOR1nBv1GqLovoixbKWmms+uDSg4ZauZRzxCemmWhGurxJEso7t8AjI ZVXbcAaJFV+eNlWFLpMRlEpGfma0f6Jna9N28cxHoFC53+0EdS2C2XSPWkuR30zxJ02196S/ zaO3hu9J8ZTs7i+vZMkcMzWQJ473O3veyZ6de+LOq5qwOMGLO6RGCghzqYGwPBO1JJLwMmQm 1qOGiz/FBQ2YLgyTh3ukxZe4ilJ8OGW1XrnxoXDaZAm5Ag0EWg0ahgEQANPvpcDGYMFdkz5W 1sb/c2a6ydelDD6fkq3dWdG7ylgYp7qfApuPqVY8e0WLx3BqqcRSJ5zgnFMPhnicXCJIm4Ag UJnKn6uZplCR+ewbDf7EcnF3l08iiHxCAsOzyVoMOByMMF24x4ZGffMtMoATnic7mGWvAaEp wKVGIeQWslY+cYRfedMkxytwD96nIUsh7MF16KkcJYes6DeZ1p1e/1UOuArHGMJ7aRT77UUJ r7cf/GVwPYLfBjVt9j/5Ft/PIfsjn3A8WjGKQ+wSA03ck63jea1WLGXUFXeGNm3kQX7q/Kz2 h+TUvTYaI4mQUj2W3v2DX/6dFlC3qX3gV/pg0i5MG9J//mYfcf/svIoP/IHf6jlj8QMguPih FdZSO5oj5Ms0UX4q5wcvl3sF4DtZJq6DathJj1laUMOxkX0ZUy7dA0HO6ggJ9qp2qxIb3SlY Y3KdXw9kM9/PkGFXAbY/gqwWSoYc4PEE0aIDro+OYMMjoVLCD0P8ocKMb0fpnJR8jKVZpVqx yA0cXpnkcOGhU6gjCvrOJRXAaZYvG+4KZyOTkk7C2rqH9eenafhRe8xYsrEmKPjKdH1GJtab M+4+zZxKytkX8SNodS5pUXCGLvj/aFET/boDgHyVVCSWAJyMVVWNiZvjETh614zjz1milOXJ S6hFnHiqi5Y08r0xDVmHABEBAAGJAjYEGAEKACACGwwWIQRC5mJHqWDpvDYofA/+GhfOadDc rAUCWg0b1QAKCRD+GhfOadDcrIH6EACoGIhemgY9hHBnUagcfCSA92DvtJSm5ZjpKrZyKuGh TVWNjx+H4A++/w6pDFZHo0LCtLvJikA2dpeowBf55Lts+mDLOCSikxjTrdaV7kjtbay5MmnS ytu4GNBa84UShfX1N2JPr/b4+O/dNo1fsby7iI7tDV431PMymFMXUNrsexqPU+u24jpPNFKh /r1La7FMQn0djusE5Uvq5O6T4jFMfsNgbmHWuFME8tQBywNSgcY4SE26+O0/xGSvUCAZ1mFA 52DNtMxm+hAxwrrzKZWhX7Hx9XCsGaOWEV9iwI1pfY4xRibXogtEQShifAYVwZYOGq+fo2ka MefIkujf8o0P8UQAqk2xHCAQ6NCBRqHku7Q1Rk05GlrI2XC8zSSWoa88eha/De+ePZbdRTW9 1tdUyFN15S+r3e2+uDl4a6C068e2+gv0dDeFhmVW+ZIpdShmsGxBVMCCFz9tAwyArvSVRBjA aA5MHXGiC/IU4fuBjt0hHVQ1tbS9Ib7UFe1HryRVtzpf5ljAgEbP1aRmKIone1X0HOG17Wr4 P9grm7+TVE7aSs3zRsB5Y11pDTcRKfWpXyuiWi0rsZXyO25JkKUw4HSjaL3EttfyLBGl6K0H Q2WwHZtayb8owb/ZKWlTr6cgwY88KC1RP+kdc63zhKcJRmbeMPrvHLygk+IoG2AYbg==
- Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 02 Aug 2018 02:01:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Openpgp: preference=signencrypt
Simon Gaiser:
> Marek Marczykowski-Górecki:
>> On Wed, Aug 01, 2018 at 10:36:26AM -0400, Jason Andryuk wrote:
>>> On Mon, Jul 30, 2018 at 11:56 PM, Marek Marczykowski-Górecki
>>> <marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote:
>>>> This allows using arguments with spaces, like -append.
>>>> Stubdomain side of this require "xenstore-client: Add option for raw
>>>> in-/output" commit.
>>>
>>> I had to look up \x1b - it is ascii escape. Since I was on the
>>> www.asciitable.com, I saw \x1e is "record seperator" which might make
>>> more sense.
>>
>> Simon, do you remember why you used \x1b? Otherwise indeed changing to
>> \x1e would make sense.
>
> As far as I recall it's a mostly arbitrary choice. I think I choose 0x1b
> because I thought that ASCII escape would be very unlikely to ever
> appear in an cmdline. 0x00 would be even better but you don't want to
> handle 0x00 in bash. I'm not aware of a problem with 0x1e.
PS: If you follow the Wikipedia description [1] of the "separator"
control characters 0x1f would fit even better. But I don't think it
really matters what rare character we use.
[1]: https://en.wikipedia.org/wiki/C0_and_C1_control_codes#FS
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|