Re: [Xen-devel] [PATCH 3/6] x86/shadow: Switch shadow_domain.has_fast_mmio_entries to bool

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.08.18 at 20:34, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/mm/shadow/multi.c
> +++ b/xen/arch/x86/mm/shadow/multi.c
> @@ -563,8 +563,7 @@ _sh_propagate(struct vcpu *v,
>      {
>          /* Guest l1e maps emulated MMIO space */
>          *sp = sh_l1e_mmio(target_gfn, gflags);
> -        if ( !d->arch.paging.shadow.has_fast_mmio_entries )
> -            d->arch.paging.shadow.has_fast_mmio_entries = 1;
> +        d->arch.paging.shadow.has_fast_mmio_entries = true;

Are you sure the if() isn't intentionally there to avoid dirtying a
cacheline when the value is already as intended?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel