Re: [Xen-devel] [PATCH v17 11/13] x86/domctl: Use hvm_save_vcpu_handler

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.08.18 at 16:28, <roger.pau@xxxxxxxxxx> wrote:
> On Wed, Aug 22, 2018 at 05:02:41PM +0300, Alexandru Isaila wrote:
>> @@ -223,17 +222,37 @@ int hvm_save(struct domain *d, hvm_domain_context_t *h)
>>      /* Save all available kinds of state */
>>      for ( i = 0; i <= HVM_SAVE_CODE_MAX; i++ )
>>      {
>> -        handler = hvm_sr_handlers[i].save;
>> -        if ( handler != NULL )
>> +        struct vcpu *v;
>> +        hvm_save_vcpu_handler save_one_handler = 
>> hvm_sr_handlers[i].save_one;
>> +        hvm_save_handler handler = hvm_sr_handlers[i].save;;
> 
> Double ';'.
> 
> Also, I would expect that a device either has a global save handler
> (handler) or a per-vcpu save handler (save_one_handler), but not both
> at the same time?
> 
> In which case, I would add something like:
> 
> ASSERT(save_one_handler == NULL || handler == NULL);
> 
> In order to make sure both are not set at the same time.

I'm not sure this is worthwhile - the next patch would remove it
again right away.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel