Re: [Xen-devel] [PATCH v2 16/23] x86/p2m/pod: make it build with !CONFIG_HVM

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.08.18 at 12:54, <wei.liu2@xxxxxxxxxx> wrote:
> On Tue, Aug 28, 2018 at 04:47:53AM -0600, Jan Beulich wrote:
>> >>> On 26.08.18 at 14:19, <wei.liu2@xxxxxxxxxx> wrote:
>> > +static inline int p2m_pod_set_mem_target(struct domain *d, unsigned long 
>> > target)
>> > +{
>> > +    return 0;
>> > +}
>> 
>> This one, at the very least, should not be needed: The case block
>> in arch_memory_op() containing the only call should altogether be
>> framed by #ifdef CONFIG_HVM.
> 
> The toolstack unconditionally sets pod target when setting a domain's
> memory target. I will need to change libxl to not issue pod call for PV
> guests in that case.

Ah, I see. I also forgot to say that the entire pod sub-structure
of struct p2m_domain should also be enclosed in #ifdef CONFIG_HVM.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel