Re: [Xen-devel] [PATCH v2 19/23] x86: PIT emulation is common to both PV and HVM

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.08.18 at 14:19, <wei.liu2@xxxxxxxxxx> wrote:
> Move the file to x86 common code and change its name to emul-i8254.c.
> 
> Put HVM only code under CONFIG_HVM or is_hvm_domain.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> v2: move the whole file.
> ---
>  xen/arch/x86/Makefile     |   1 +-
>  xen/arch/x86/emul-i8254.c | 609 +++++++++++++++++++++++++++++++++++++++-
>  xen/arch/x86/hvm/Makefile |   1 +-
>  xen/arch/x86/hvm/i8254.c  | 597 +--------------------------------------
>  4 files changed, 610 insertions(+), 598 deletions(-)
>  create mode 100644 xen/arch/x86/emul-i8254.c
>  delete mode 100644 xen/arch/x86/hvm/i8254.c

On the assumption that the changes to the file are only CONFIG_HVM
additions
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Generating the diff with rename detection would have eased review
though.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel