Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.08.18 at 10:29, <olaf@xxxxxxxxx> wrote:
> --- a/xen/Kconfig.debug
> +++ b/xen/Kconfig.debug
> @@ -11,6 +11,13 @@ config DEBUG
>  
>         You probably want to say 'N' here.
>  
> +config DEBUG_INFO
> +     bool "Compile Xen with debug info"
> +     default y
> +     ---help---
> +       If you say Y here the resulting Xen will include debugging info
> +       resulting in a larger binary image.
> +
>  if DEBUG || EXPERT = "y"

Perhaps better move your addition into this conditional section?

> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -55,7 +55,10 @@ endif
>  
>  CFLAGS += -nostdinc -fno-builtin -fno-common
>  CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith
> -CFLAGS += -pipe -g -D__XEN__ -include $(BASEDIR)/include/xen/config.h
> +ifeq ($(CONFIG_DEBUG_INFO),y)
> +CFLAGS += -g

Note how a few lines down from here we already use CFLAGS-y.
Please make this 

CFLAGS-$(CONFIG_DEBUG_INFO) += -g

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel