Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Aug 31, 2018 at 09:51:50AM +0100, Andrew Cooper wrote:
> On 31/08/18 09:41, Jan Beulich wrote:
> >>>> On 31.08.18 at 10:32, <wei.liu2@xxxxxxxxxx> wrote:
> >> On Fri, Aug 31, 2018 at 10:29:21AM +0200, Olaf Hering wrote:
> >>> Creating debug info during build is not strictly required at runtime.
> >>> Make it optional by introducing a new Kconfig knob "DEBUG_INFO".
> >>> This slightly reduces build time and diskusage, if disabled.
> >>>
> >>> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> >>> ---
> >>>  xen/Kconfig.debug | 7 +++++++
> >>>  xen/Rules.mk      | 5 ++++-
> >>>  2 files changed, 11 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
> >>> index 380c4e8d75..1d8c2c94a9 100644
> >>> --- a/xen/Kconfig.debug
> >>> +++ b/xen/Kconfig.debug
> >>> @@ -11,6 +11,13 @@ config DEBUG
> >>>  
> >>>     You probably want to say 'N' here.
> >>>  
> >>> +config DEBUG_INFO
> >>> + bool "Compile Xen with debug info"
> >>> + default y
> >> At the very least this should be default DEBUG
> > I disagree - -g is being passed to the compiler unconditionally at
> > present.
> 
> +1
> 
> Distro packagers need to build debuginfo packages, and having a release
> build of Xen with xen-syms lacking all the debug symbols is quite useless.

I see. I misunderstood the intent.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel