Re: [Xen-devel] [PATCH 1/5] x86/hvm: Switch hvm_allow_get_param() to use a whitelist

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.09.18 at 17:21, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 06/09/18 09:56, Paul Durrant wrote:
>>> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
>>> index c22bf0b..96a6323 100644
>>> --- a/xen/arch/x86/hvm/hvm.c
>>> +++ b/xen/arch/x86/hvm/hvm.c
>>> @@ -4350,7 +4350,7 @@ static int hvm_allow_get_param(struct domain *d,
>>>
>>>      switch ( a->index )
>>>      {
>>> -    /* The following parameters can be read by the guest. */
>>> +        /* The following parameters can be read by the guest and 
>>> toolstack. */
>> Intentional indentation change? I guess so since you do it again below, but 
>> just checking.
> 
> Yes - this is where BSD style puts comments, as you are inside the
> braced scope of the switch statement.

Well, I'm inclined to support Paul here, no matter what BSD style may
have to say. Our own style description doesn't spell out anything
either way...

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel