Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.09.18 at 15:21, <JBeulich@xxxxxxxx> wrote:
>>>> On 31.08.18 at 10:43, <JBeulich@xxxxxxxx> wrote:
>>>>> On 31.08.18 at 10:29, <olaf@xxxxxxxxx> wrote:
>>> --- a/xen/Kconfig.debug
>>> +++ b/xen/Kconfig.debug
>>> @@ -11,6 +11,13 @@ config DEBUG
>>>  
>>>       You probably want to say 'N' here.
>>>  
>>> +config DEBUG_INFO
>>> +   bool "Compile Xen with debug info"
>>> +   default y
>>> +   ---help---
>>> +     If you say Y here the resulting Xen will include debugging info
>>> +     resulting in a larger binary image.
>>> +
>>>  if DEBUG || EXPERT = "y"
>> 
>> Perhaps better move your addition into this conditional section?
> 
> So this was a bad suggestion after all - with DEBUG=n DEBUG_INFO is
> now implicitly n as well. The section needs to be moved back to where
> you had it as per above, with the _prompt_ depending on
> DEBUG || EXPERT="y".

Furthermore - is COVERAGE without DEBUG_INFO of any use? Are there
perhaps any other dependencies (I think/hope live patching logic doesn't
depend on debug info)?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel