Re: [Xen-devel] [PATCH v19 13/13] x86/domctl: Don't pause the whole domain if only getting vcpu state

[Isaila Alexandru <aisaila@xxxxxxxxxxxxxxx>]

On Mon, 2018-09-10 at 07:25 -0600, Jan Beulich wrote:
> > > > On 10.09.18 at 14:36, <aisaila@xxxxxxxxxxxxxxx> wrote:
> > 
> > --- a/xen/arch/x86/hvm/save.c
> > +++ b/xen/arch/x86/hvm/save.c
> > @@ -155,6 +155,11 @@ int hvm_save_one(struct domain *d, unsigned
> > int typecode, unsigned int instance,
> >      if ( !ctxt.data )
> >          return -ENOMEM;
> >  
> > +    if ( hvm_sr_handlers[typecode].kind == HVMSR_PER_VCPU )
> > +        vcpu_pause(d->vcpu[instance]);
> 
> Is there any reason why you don't use v here and ...

There is not reason but I did not want to modify the reviewed patch
further

Alex
> > +    else
> > +        domain_pause(d);
> > +
> >      if ( (rv = hvm_sr_handlers[typecode].save(v, &ctxt)) != 0 )
> >          printk(XENLOG_G_ERR "HVM%d save: failed to save type
> > %"PRIu16" (%d)\n",
> >                 d->domain_id, typecode, rv);
> > @@ -186,6 +191,11 @@ int hvm_save_one(struct domain *d, unsigned
> > int typecode, unsigned int instance,
> >          }
> >      }
> >  
> > +    if ( hvm_sr_handlers[typecode].kind == HVMSR_PER_VCPU )
> > +        vcpu_unpause(d->vcpu[instance]);
> 
> ... here?
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel