Re: [Xen-devel] [PATCH v19 13/13] x86/domctl: Don't pause the whole domain if only getting vcpu state

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.09.18 at 15:29, <aisaila@xxxxxxxxxxxxxxx> wrote:
> On Mon, 2018-09-10 at 07:25 -0600, Jan Beulich wrote:
>> > > > On 10.09.18 at 14:36, <aisaila@xxxxxxxxxxxxxxx> wrote:
>> > 
>> > --- a/xen/arch/x86/hvm/save.c
>> > +++ b/xen/arch/x86/hvm/save.c
>> > @@ -155,6 +155,11 @@ int hvm_save_one(struct domain *d, unsigned
>> > int typecode, unsigned int instance,
>> >      if ( !ctxt.data )
>> >          return -ENOMEM;
>> >  
>> > +    if ( hvm_sr_handlers[typecode].kind == HVMSR_PER_VCPU )
>> > +        vcpu_pause(d->vcpu[instance]);
>> 
>> Is there any reason why you don't use v here and ...
> 
> There is not reason but I did not want to modify the reviewed patch
> further

But you should (and if in doubt drop the previously supplied tags),
so that the correlation of the above with ...

>> > +    else
>> > +        domain_pause(d);
>> > +
>> >      if ( (rv = hvm_sr_handlers[typecode].save(v, &ctxt)) != 0 )

... the actual call becomes as clear as possible. My R-b does not stand
without this adjustment, but it does with it in place. _Provided_ it is
correct, and provided the one remaining patch is now also correct, I'd
be happy to make the change while committing.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel