Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.09.18 at 19:51, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 10/09/18 14:29, Jan Beulich wrote:
>>>>> On 10.09.18 at 15:21, <JBeulich@xxxxxxxx> wrote:
>>>>>> On 31.08.18 at 10:43, <JBeulich@xxxxxxxx> wrote:
>>>>>>> On 31.08.18 at 10:29, <olaf@xxxxxxxxx> wrote:
>>>>> --- a/xen/Kconfig.debug
>>>>> +++ b/xen/Kconfig.debug
>>>>> @@ -11,6 +11,13 @@ config DEBUG
>>>>>  
>>>>>     You probably want to say 'N' here.
>>>>>  
>>>>> +config DEBUG_INFO
>>>>> + bool "Compile Xen with debug info"
>>>>> + default y
>>>>> + ---help---
>>>>> +   If you say Y here the resulting Xen will include debugging info
>>>>> +   resulting in a larger binary image.
>>>>> +
>>>>>  if DEBUG || EXPERT = "y"
>>>> Perhaps better move your addition into this conditional section?
>>> So this was a bad suggestion after all - with DEBUG=n DEBUG_INFO is
>>> now implicitly n as well. The section needs to be moved back to where
>>> you had it as per above, with the _prompt_ depending on
>>> DEBUG || EXPERT="y".
>> Furthermore - is COVERAGE without DEBUG_INFO of any use?
> 
> Yes - very much so.
> 
> From a "how much of my binary does do my tests cover" point of view, you
> want the release binary rather than the debug binary.

Did you confuse DEBUG and DEBUG_INFO? My question was because
I suspect the analyzer to want/need to have debug information available.

>> Are there
>> perhaps any other dependencies (I think/hope live patching logic doesn't
>> depend on debug info)?
> 
> The livepatch build depends on xen-syms containing all the debug
> information, but the runtime logic doesn't, I believe.

But if the livepatch build requires debug information (rather than just
the ELF symbol table), then it _is_ depending on DEBUG_INFO.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel