Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.09.18 at 15:25, <Paul.Durrant@xxxxxxxxxx> wrote:
>>  -----Original Message-----
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Sent: 12 September 2018 14:20
>> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
>> Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>; Kevin Tian
>> <kevin.tian@xxxxxxxxx>; xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
>> Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops
>> 
>> >>> On 12.09.18 at 14:53, <Paul.Durrant@xxxxxxxxxx> wrote:
>> > The function will never return its results to a guest, PV or HVM, so I
>> > really don't see the concern. It's a low level function, for Xen's internal
>> > use only. It's essentially the equivalent of a p2m lookup function and
>> > there's no way we'd ever expose the results of such a lookup to the guest
>> > either.
>> 
>> Oh, that was utter confusion on my part then, and I'm sorry for all
>> the noise. I've got mislead by the titles of this patch and patches
>> 13 and 14, all of which have "iommu_ops" as parts of them.
>> 
> 
> I recently noticed this name overloading so sorry for leading you astray. I 
> will seriously consider renaming the hypercall when I re-work the later 
> patches.

The hypercall name is fine, I think. Perhaps the distinction
could already be made more clear by using iommu_ops for the
internal interface(s) (matching their structure name) and
iommu_op / iommu_op-s for the hypercall based operations,
seeing that the structure is names xen_iommu_op?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel