[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
- To: YueHaibing <yuehaibing@xxxxxxxxxx>, <davem@xxxxxxxxxxxxx>, <dmitry.tarnyagin@xxxxxxxxxxx>, <wg@xxxxxxxxxxxxxx>, <mkl@xxxxxxxxxxxxxx>, <michal.simek@xxxxxxxxxx>, <hsweeten@xxxxxxxxxxxxxxxxxxx>, <madalin.bucur@xxxxxxx>, <pantelis.antoniou@xxxxxxxxx>, <claudiu.manoil@xxxxxxx>, <leoyang.li@xxxxxxx>, <linux@xxxxxxxxxxxxxxx>, <sammy@xxxxxxxxx>, <ralf@xxxxxxxxxxxxxx>, <nico@xxxxxxxxxxx>, <steve.glendinning@xxxxxxxxxxx>, <f.fainelli@xxxxxxxxx>, <w-kwok2@xxxxxx>, <m-karicheri2@xxxxxx>, <t.sailer@xxxxxxxxxxxxxx>, <jreuter@xxxxxxxx>, <kys@xxxxxxxxxxxxx>, <haiyangz@xxxxxxxxxxxxx>, <wei.liu2@xxxxxxxxxx>, <paul.durrant@xxxxxxxxxx>, <arvid.brodin@xxxxxxxx>, <pshelar@xxxxxxx>
- From: Grygorii Strashko <grygorii.strashko@xxxxxx>
- Date: Thu, 20 Sep 2018 12:04:58 -0500
- Cc: dev@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, devel@xxxxxxxxxxxxxxxxxxxxxx, linux-hams@xxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 20 Sep 2018 17:06:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09/20/2018 07:32 AM, YueHaibing wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
>
May be I missed smth, but it's acceptable to report standard error codes from
.xmit() callback as per dev_xmit_complete().
--
regards,
-grygorii
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
