[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
- To: David Miller <davem@xxxxxxxxxxxxx>
- From: YueHaibing <yuehaibing@xxxxxxxxxx>
- Date: Fri, 21 Sep 2018 09:33:24 +0800
- Cc: dmitry.tarnyagin@xxxxxxxxxxx, madalin.bucur@xxxxxxx, linux-mips@xxxxxxxxxxxxxx, linux@xxxxxxxxxxxxxxx, pantelis.antoniou@xxxxxxxxx, kys@xxxxxxxxxxxxx, t.sailer@xxxxxxxxxxxxxx, dev@xxxxxxxxxxxxxxx, f.fainelli@xxxxxxxxx, arvid.brodin@xxxxxxxx, michal.simek@xxxxxxxxxx, pshelar@xxxxxxx, m-karicheri2@xxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, jreuter@xxxxxxxx, sammy@xxxxxxxxx, grygorii.strashko@xxxxxx, w-kwok2@xxxxxx, haiyangz@xxxxxxxxxxxxx, steve.glendinning@xxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, claudiu.manoil@xxxxxxx, paul.durrant@xxxxxxxxxx, mkl@xxxxxxxxxxxxxx, linux-hams@xxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, wei.liu2@xxxxxxxxxx, nico@xxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ralf@xxxxxxxxxxxxxx, leoyang.li@xxxxxxx, hsweeten@xxxxxxxxxxxxxxxxxxx, wg@xxxxxxxxxxxxxx, devel@xxxxxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx
- Delivery-date: Fri, 21 Sep 2018 01:33:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2018/9/20 23:50, David Miller wrote:
> From: YueHaibing <yuehaibing@xxxxxxxxxx>
> Date: Thu, 20 Sep 2018 20:32:44 +0800
>
>> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
>> which is a typedef for an enum type, so make sure the implementation in
>> this driver has returns 'netdev_tx_t' value, and change the function
>> return type to netdev_tx_t.
>
> I would advise you not to send so many of these changes as a group.
>
> If one of the patches needs feedback addressed, which is already the
> case, you will have to resubmit the entire series all over again with
> the fixes.
>
Yes, I will send it separately after test and review again.
Thank you for your advice.
> .
>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
