Re: [Xen-devel] [PATCH v2] x86: fix comment on super page alignment requirement

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.09.18 at 15:46, <wei.liu2@xxxxxxxxxx> wrote:
> @@ -987,6 +974,20 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>          highmem_start &= ~((1UL << L3_PAGETABLE_SHIFT) - 1);
>  #endif
>  
> +    /*
> +     * Iterate backwards over all superpage-aligned RAM regions.
> +     *
> +     * We require superpage alignment because the boot allocator is
> +     * not yet initialised. Hence we can only map superpages in the
> +     * address range BOOTSTRAP_MAP_BASE to BOOTSTRAP_MAP_LIMIT, as

Well, as said, mentioning BOOTSTRAP_MAP_LIMIT here is then not in
line with the code. I think BOOTSTRAP_MAP_LIMIT should really be
#undef-ed right after the last function using it.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel