Re: [Xen-devel] [PATCH v2] x86: fix comment on super page alignment requirement

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Sep 24, 2018 at 08:08:52AM -0600, Jan Beulich wrote:
> >>> On 24.09.18 at 15:46, <wei.liu2@xxxxxxxxxx> wrote:
> > @@ -987,6 +974,20 @@ void __init noreturn __start_xen(unsigned long mbi_p)
> >          highmem_start &= ~((1UL << L3_PAGETABLE_SHIFT) - 1);
> >  #endif
> >  
> > +    /*
> > +     * Iterate backwards over all superpage-aligned RAM regions.
> > +     *
> > +     * We require superpage alignment because the boot allocator is
> > +     * not yet initialised. Hence we can only map superpages in the
> > +     * address range BOOTSTRAP_MAP_BASE to BOOTSTRAP_MAP_LIMIT, as

Okay. The address range should be changed to "BOOTSTRAP_MAP_BASE to
4GB".

> 
> Well, as said, mentioning BOOTSTRAP_MAP_LIMIT here is then not in
> line with the code. I think BOOTSTRAP_MAP_LIMIT should really be
> #undef-ed right after the last function using it.

Okay.

Wei.

> 
> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel