Re: [Xen-devel] [PATCH 1/2] x86: make sure module array is large enough in pvh-boot.c

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.09.18 at 10:24, <wei.liu2@xxxxxxxxxx> wrote:
> The relocation code in __start_xen requires one extra element in the
> module array. By the looks of it the temporary array is already large
> enough. Add a BUG_ON to catch any issue in the future.
> 
> While at it, turn another ASSERT to BUG_ON as well.

Hmm, a little strange - I thought we had agreed on panic() before.
The extra output BUG_ON() produces is unlikely to be helpful here.
With this switched to panic() it certainly can have my ack.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel